Adding support for live preview #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! ❤️ |
|
Awesome! I wasn't sure whether I should update the package.json version,manifest and change log. I did anyway so that you could potentially release it right away without any changes, but you may want to double check I did it to your standard before making a release. |
|
I use the semantic release to automatically update changelogs and add tags, but it's all good. I will make a release as soon as I have access to my workstation. Thank you once again for your contribution and sorry for the lack of responsiveness from my side. |
|
Whoopsie. Merging this without a corresponding release means the plugin is currently uninstallable - #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsidian live preview required the transition from codemirror 5 to codemirror 6. This meant obsidian had to change their API a bit. In order to get this working with the new API (the main issue was the auto select mode) I had to implement some of the functionality previously provided by code mirror from scratch. Below is a list of the major changes I made.
Changes
Replaced the
WordBoundriesinterface in core withEditorRangefrom the obsidian packageMoves
isUrlandisImgEmbedout ofgetReplaceTextand into stand alone functionsAdded documentation for
getReplaceTextfunctionAdded documentation for
NothingSelectedenumChanged
somethingSelected()check at the end ofUrlIntoSelectiontoselectedText === ""becausesomethingSelected()was returning the wrong value when something was selectedAdded
findWordAtfunction to mimic the functionality of the codemirror 5editor.findWordAtfunctionChanged some formatting to make the code a bit more readable